RFR: 8346916: [REDO] align_up has potential overflow

Kim Barrett kbarrett at openjdk.org
Sun Feb 23 10:02:58 UTC 2025


On Fri, 21 Feb 2025 20:59:34 GMT, Dean Long <dlong at openjdk.org> wrote:

> I don't see where we check the return value of align_up_or_min for the changes in src/hotspot/share/gc/shared/gcArguments.cpp. If tests fail because of align_up, maybe the test should be fixed?

I share @dean-long concerns.  This PR doesn't seem like the right direction.  I think the earlier PR was correct, and
just uncovered problems elsewhere that should be fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23711#issuecomment-2676749537


More information about the hotspot-dev mailing list