RFR: 8348426: Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file [v8]

[Ashutosh Mehra]

On Tue, 25 Feb 2025 06:04:01 GMT, Ioi Lam <iklam at openjdk.org> wrote:

> _index is updated to use the runtime vtables after CppVtables::dumptime_init(), so we must check _archived_cpp_vtptrs as well.

That's right. I agree with your point, but I think the method `is_valid_shared_method` is not used during dump time. One of the caller is `Method::restore_unshareable_info` which is invoked during archive loading, and the other caller is related to JNI APIs to call Java methods. So the context of the call makes me think the current condition is sufficient. But again, it can be argued that this function can break if it gets used in some other context where the current condition is not sufficient.
I think I am fine with this change.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23484#discussion_r1969293214