RFR: 8344009: Improve compiler memory statistics [v4]

[Thomas Stuefe]

On Mon, 24 Feb 2025 10:19:42 GMT, Roberto Castañeda Lozano <rcastanedalo at openjdk.org> wrote:

>> Thomas Stuefe has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   avoid Thread::current in high traffic chunk alloc path
>
> src/hotspot/share/compiler/compilationMemoryStatistic.cpp line 1093:
> 
>> 1091:       Compile::TracePhase tp(Phase::_t_testTimer1);
>> 1092:       Arena ar(MemTag::mtCompiler, Arena::Tag::tag_reglive);
>> 1093:       ar.Amalloc(2 * M); // phase-local peak, should show up at MY-TESTPHASE-2
> 
> The reference to `MY-TESTPHASE-2` seems obsolete.

Removed

> test/hotspot/jtreg/compiler/print/CompileCommandMemLimit.java line 105:
> 
>> 103:         // by phase end. So, in the phase timeline these 2MB must show up as "significant temporary peak".
>> 104:         // In testPhase2, we allocate 32MB from resource area, which is leaked until the end of the compilation. This
>> 105:         // means that these 32MB will show up as permanent memory increase in the phasetimeline.
> 
> The references to `testPhase` seem obsolete, do you mean `Phase::_t_testTimer1` and `Phase::_t_testTimer2`?

Right you are

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23530#discussion_r1969475279
PR Review Comment: https://git.openjdk.org/jdk/pull/23530#discussion_r1969475077