RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v30]

Afshin Zafari azafari at openjdk.org
Tue Feb 25 11:06:27 UTC 2025


On Mon, 24 Feb 2025 20:01:18 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   test file got back, fixed coding style
>
> src/hotspot/share/nmt/virtualMemoryTracker.hpp line 381:
> 
>> 379:   bool remove_uncommitted_region (address base_addr, size_t size);
>> 380:   bool remove_released_region    (address base_addr, size_t size);
>> 381:   bool remove_released_region    (ReservedMemoryRegion* rgn);
> 
> Why are they returning `bool` ? I don't see the return value being used anywhere?

Good catch. They are removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1969540784


More information about the hotspot-dev mailing list