RFR: 8350182: [s390x] Relativize locals in interpreter frames [v2]

Amit Kumar amitkumar at openjdk.org
Tue Feb 25 13:18:39 UTC 2025


On Tue, 25 Feb 2025 08:14:29 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:

>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use Z_R0 as helper
>
> src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp line 1138:
> 
>> 1136:   // z_ijava_state->locals = Z_esp + parameter_count bytes
>> 1137: 
>> 1138:   __ z_ldgr(Z_F1, Z_R1); // preserve Z_R1, holding cache offset
> 
> How expensive is this?
> I remember those GPR <-> FPR transfers to be convenient, but inefficient. But that my have changed.
> Would Z_R0 be available or is it occupied as well?

updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23660#discussion_r1969760795


More information about the hotspot-dev mailing list