RFR: 8345125: Aarch64: Add aarch64 backend for Float16 scalar operations [v2]
Bhavana Kilambi
bkilambi at openjdk.org
Tue Feb 25 19:49:01 UTC 2025
On Mon, 24 Feb 2025 17:06:59 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Address review comments
>
> src/hotspot/cpu/aarch64/aarch64.ad line 17275:
>
>> 17273:
>> 17274: // This pattern would result in the following instructions (the first two are for ConvF2HF
>> 17275: // and the last instruction is for ReinterpretS2HF) -
>
> Suggestion:
>
> // Without this pattern, (ReinterpretS2HF (ConvF2HF src)) would result in the following instructions (the first two for ConvF2HF
> // and the last instruction for ReinterpretS2HF) -
>
> Reads a little better, I think?
Addressed this in the new patch.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23748#discussion_r1970437734
More information about the hotspot-dev
mailing list