RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v31]

Afshin Zafari azafari at openjdk.org
Wed Feb 26 14:05:25 UTC 2025


On Wed, 26 Feb 2025 14:01:07 GMT, Afshin Zafari <azafari at openjdk.org> wrote:

>> test/hotspot/gtest/nmt/test_vmatree.cpp line 221:
>> 
>>> 219:   EXPECT_EQ(-50, diff.tag[NMTUtil::tag_to_index(mtTest)].commit);
>>> 220: }
>>> 221: 
>> 
>> What's going on with this test?
>
> It checks the `use_tag_inplace` in committing a region, by passing `true` to the last parameter of the `VMATree::commit_mapping`. It is expected that the existing tag from the previous region to be copied to this new region. The mem tag of the `rd2` (`mtNone`) should not be used for the new committed region.

Also, it is skipped until the corresponding PR get integrated, otherwise it fails.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1971644873


More information about the hotspot-dev mailing list