RFR: 8343840: Rewrite the ObjectMonitor lists [v2]

[Fredrik Bredberg]

On Thu, 27 Feb 2025 13:56:15 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> Fredrik Bredberg has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update after review by David and Coleen.
>
> src/hotspot/cpu/x86/c2_MacroAssembler_x86.cpp line 418:
> 
>> 416:   // have released the lock.
>> 417:   // Refer to the comments in synchronizer.cpp for how we might encode extra
>> 418:   // state in _succ so we can avoid fetching entry_list.
> 
> I there is no comment in synchronizer about this (that I can find) and whether or not this is a good idea, can you remove this line with this change?

Removed

> src/hotspot/share/runtime/objectMonitor.hpp line 79:
> 
>> 77:   void set_bad_pointers() {
>> 78: #ifdef ASSERT
>> 79:     // Diagnostic hygiene ...
> 
> hygiene seems like the wrong word here.  Can you remove this comment?

Removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23421#discussion_r1974271052
PR Review Comment: https://git.openjdk.org/jdk/pull/23421#discussion_r1974271724