RFR: 8343840: Rewrite the ObjectMonitor lists [v2]

Fredrik Bredberg fbredberg at openjdk.org
Thu Feb 27 20:59:55 UTC 2025


On Mon, 10 Feb 2025 12:51:43 GMT, Fredrik Bredberg <fbredberg at openjdk.org> wrote:

>> src/hotspot/share/jvmci/vmStructs_jvmci.cpp line 332:
>> 
>>> 330:   volatile_nonstatic_field(ObjectMonitor,      _owner,                                        int64_t)                               \
>>> 331:   volatile_nonstatic_field(ObjectMonitor,      _recursions,                                   intptr_t)                              \
>>> 332:   volatile_nonstatic_field(ObjectMonitor,      _EntryListTail,                                ObjectWaiter*)                         \
>> 
>> You may need to coordinate with @mur47x111 to see what graal does with this field.  I suspect the graal code also checks both ctx and EntryList in the unlock fast path and now only needs to check _EntryList.  In which case we don't need to export EntryListTail.
>
> Thanks for the heads up @coleenp . I was planing on contacting the Graal team when this PR gets closer to getting integrated. I'll delete the `_EntryListTail` export, and make sure to ask for a review from @mur47x111  when that time comes.

They seem to have everything under control: [[JDK-8349711] Adapt JDK-8343840: Rewrite the ObjectMonitor lists](https://github.com/oracle/graal/pull/10757)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23421#discussion_r1974327790


More information about the hotspot-dev mailing list