RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v32]
Johan Sjölen
jsjolen at openjdk.org
Fri Feb 28 10:22:17 UTC 2025
On Thu, 27 Feb 2025 20:58:13 GMT, Afshin Zafari <azafari at openjdk.org> wrote:
>> Not sure I agree with Johan's comment here - in memBaseline.cpp we use MemTracker a lot, so adding these APIs make sense there, otherwise we would have to split work between MemTracker and VirtualMemoryTracker.
>>
>> Personally I like this way better.
>
> Done.
I'm not sure what you mean with using MemTracker a lot, we use it twice: Once for taking the NMT lock, and once for checking the NMT level.
The current structure of NMT is that `MemTracker` is responsible for taking locks and checking if NMT is enabled, and then calling the underlying APIs. The underlying APIs are only meant to be called directly by other NMT components, such as `MemBaseline`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975168022
More information about the hotspot-dev
mailing list