RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v32]

[Afshin Zafari]

On Thu, 27 Feb 2025 13:44:48 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   removed UseFlagInPlace test.
>
> src/hotspot/share/nmt/regionsTree.hpp line 30:
> 
>> 28: #include "nmt/nmtCommon.hpp"
>> 29: #include "nmt/vmatree.hpp"
>> 30: #include "nmt/virtualMemoryTracker.hpp"
> 
> This doesn't seem used. However, you do not include the `nmt/nmtNativeCallStackStorage.hpp` header.

Done.

> src/hotspot/share/nmt/regionsTree.hpp line 90:
> 
>> 88:       return true;
>> 89:     });
>> 90:   }
> 
> Move to `cpp` file, wrap in `#ifdef ASSERT`.

Done.

> src/hotspot/share/nmt/virtualMemoryTracker.cpp line 105:
> 
>> 103:     //                " vms-committed: %zu",
>> 104:     //                str, NMTUtil::tag_to_name(tag), (long)reserve_delta, (long)commit_delta, reserved, committed);
>> 105:   };
> 
> Any plan regarding this?

Will be commented out after https://github.com/openjdk/jdk/pull/23771.
Until then, the error messages will pollute the output and corrupt the jdk-image.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975432017
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975429334
PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1975431804