RFR: JDK-8216437 : PPC64: Add intrinsic for GHASH algorithm [v28]

Martin Doerr mdoerr at openjdk.org
Fri Feb 28 21:46:57 UTC 2025


On Thu, 27 Feb 2025 13:40:51 GMT, Suchismith Roy <sroy at openjdk.org> wrote:

>> JBS Issue : [JDK-8216437](https://bugs.openjdk.org/browse/JDK-8216437)
>> 
>> Currently acceleration code for GHASH is missing for PPC64. 
>> 
>> The current implementation utlilises SIMD instructions on Power and uses Karatsuba multiplication for obtaining the final result.
>
> Suchismith Roy has updated the pull request incrementally with one additional commit since the last revision:
> 
>   use vsplitsb

src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 562:

> 560:                               VectorRegister vReducedLow, VectorRegister vTmp8, VectorRegister vTmp9,
> 561:                               VectorRegister vCombinedResult, VectorRegister vSwappedH) {
> 562:     assert(masm != nullptr, "MacroAssembler pointer is null");

I think this assertion is not really beneficial. Who would pass nullptr?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20235#discussion_r1976042069


More information about the hotspot-dev mailing list