RFR: 8346193: CrashGCForDumpingJavaThread do not trigger expected crash build with clang17 [v4]

SendaoYan syan at openjdk.org
Thu Jan 2 02:43:02 UTC 2025


On Wed, 1 Jan 2025 07:44:35 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use guarantee(!CrashGCForDumpingJavaThread, "") to generate jvm crash
>
> src/hotspot/share/runtime/frame.cpp line 1166:
> 
>> 1164:   // simulate GC crash here to dump java thread in error report
>> 1165:   if (CrashGCForDumpingJavaThread) {
>> 1166:     guarantee(!CrashGCForDumpingJavaThread, "");
> 
> The surrounding `if` is no longer needed.

Thanks, the curly braces has been removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22757#discussion_r1900506079


More information about the hotspot-dev mailing list