RFR: 8346193: CrashGCForDumpingJavaThread do not trigger expected crash build with clang17 [v5]

[SendaoYan]

On Thu, 2 Jan 2025 03:07:57 GMT, SendaoYan <syan at openjdk.org> wrote:

>> src/hotspot/share/runtime/frame.cpp line 1166:
>> 
>>> 1164:   // simulate GC crash here to dump java thread in error report
>>> 1165:   if (CrashGCForDumpingJavaThread)
>>> 1166:     guarantee(!CrashGCForDumpingJavaThread, "");
>> 
>> Besides being contrary to the HotSpot Style Guide, that isn't at all what I
>> meant.  We don't need to test CrashGCForDumpingJavaThread before testing it
>> again int the guarantee.
>
> Sorry, got it now.
> The duplicate `CrashGCForDumpingJavaThread` check has been removed.

1. --with-debug-level=optimized: `java -XX:+CrashGCForDumpingJavaThread -version` do not trigger jvm crash and print version meaasge.
2. --with-debug-level=release: `java -XX:+CrashGCForDumpingJavaThread -version` report VM option 'CrashGCForDumpingJavaThread' is develop and is available only in debug version of VM.
3. --with-debug-level=fastdebug: `java -XX:+CrashGCForDumpingJavaThread -version` trigger jvm crash correctly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22757#discussion_r1900515180