RFR: 8346193: CrashGCForDumpingJavaThread do not trigger expected crash build with clang17 [v6]

Kim Barrett kbarrett at openjdk.org
Thu Jan 2 07:45:38 UTC 2025


On Thu, 2 Jan 2025 05:20:27 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Remove duplicate CrashGCForDumpingJavaThread check
>
> Looks good.

> @kimbarrett just for my understanding, Can't we do something like this:
> 
> ```c++
>   if (CrashGCForDumpingJavaThread) {
>     raise(SIGSEGV);
>   }
> ```

I think that would also work, but has to go through the complexities of signal handling and reporting, and doesn't
provide any useful context in the error message, only in the hs_err stack trace.  So I think the proposed use of
`guarantee` is better.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22757#issuecomment-2567382372


More information about the hotspot-dev mailing list