RFR: 8346193: CrashGCForDumpingJavaThread do not trigger expected crash build with clang17 [v2]

[Thomas Stuefe]

On Tue, 31 Dec 2024 10:40:43 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Or do we really need to support this in "optimized" builds?  I'm not sure who uses this.
>
>> OTOH, based on the comment's description of what this is needed for, why not just `guarantee(!CrashGCForDumpingJavaThread, "")` ?
> 
> Previously I am not quite sure that use `ShouldNotReachHere()` instead of `*t = 'c'` could break the original test intention or not. Use `guarantee(!CrashGCForDumpingJavaThread, "")` make the original test [check](https://github.com/openjdk/jdk/blob/master/test/hotspot/jtreg/runtime/ErrorHandling/TestDwarf.java#L103) success. So I think use `guarantee(!CrashGCForDumpingJavaThread, "")` will acceptable. The code has been changed. Thanks your advices.

> Or do we really need to support this in "optimized" builds? I'm not sure who uses this.

I thought we wanted to remove it (https://bugs.openjdk.org/browse/JDK-8183287)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22757#discussion_r1901549131