RFR: 8346717: serviceability/dcmd/vm/SystemDumpMapTest.java failing on Windows with "Stack base not yet set for thread id" [v2]

[Simon Tooke]

On Wed, 25 Dec 2024 00:26:30 GMT, Leonid Mesnik <lmesnik at openjdk.org> wrote:

>> Simon Tooke has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   refine jtreg tags per review
>
> test/hotspot/jtreg/serviceability/dcmd/vm/SystemMapTest.java line 39:
> 
>> 37:  *          java.management
>> 38:  *          jdk.internal.jvmstat/sun.jvmstat.monitor
>> 39:  * @run testng/othervm -XX:+UsePerfData -XX:+UseZGC SystemMapTest
> 
> No need to add separate testcase for ZGC. It is expected that  hotspot tests are usually executed to ensure that all functionality works with any GC.
> If you want to add it to ensure that  regression testcase is always executed even no ZGC is set then please 
> 1) add
> `* @requires vm.gc.Z`
> So testcase is not executed if non-ZGC GC (Parallel/Serial etc) is set explicitly.
> 2) Add 
> ` * @bug 8346717`
> 3) Add id like
> `* @test id=zgc`
> to make testcase name clearer.

@lmesnik thank you for the review!  I have updated the jtreg tags as suggested.  My intent is to ensure this test is run with and without ZGC as the expected results differ.  I believe I can accomplish this with these two test definitions?  I've seen similar test definitions elsewhere in the jdk.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22870#discussion_r1902126817