RFR: 8329549: Remove FORMAT64_MODIFIER [v2]

David Holmes dholmes at openjdk.org
Tue Jan 7 13:18:42 UTC 2025


On Tue, 7 Jan 2025 12:39:47 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This change removes FORMAT64_MODIFIER but adds another INT64_FORMAT_X_0_ macro to specify not having leading "0x" in the output.  Suggestions for better macro name welcome.
>> GHA tested.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Use INT64_FORMAT_0

src/hotspot/share/utilities/globalDefinitions.hpp line 136:

> 134: 
> 135: // Format with padding without leading 0x
> 136: #define INT64_FORMAT_0           "%016"       PRIx64

AFAICS the os.cpp usages want unsigned (`%016llx`), so this should be UINT64_FORMAT_0

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22918#discussion_r1905440696


More information about the hotspot-dev mailing list