RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v2]

[David Holmes]

On Wed, 8 Jan 2025 13:23:29 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> I disagree. It seems to me that breaking the abstraction like that is just asking for trouble.
>
> Yes, I think it's fine to say !WINDOWS instead of listing all the posix ports.  We've been avoiding dispatch files and once it reaches a threshold of too many #ifdef !WINDOWS #include posix.hpp one, then we could add another macro like the OS_CPU one.
> 
> Also the copyright script added 2025 for these because they started with 2024 so it's sort of a bug in the script but not really solvable because it doesn't know that you didn't check this in in 2024.

> It seems to me that breaking the abstraction like that is just asking for trouble.

Sorry but what "abstraction" are you referring to?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22890#discussion_r1908044703