RFR: 8346478: RISC-V: Refactor add/sub assembler routines [v7]

Fei Yang fyang at openjdk.org
Thu Jan 9 03:34:18 UTC 2025


> Hi, please consider this cleanup change.
> 
> Currently, we have mixed use of `addi` and `add(int64_t)`/`sub(int64_t)`. The former adds a 12-bit immediate while the latter
> does not have a constraint on the immediate range. We should use `addi` when possible, which would help save one runtime check about the immediate range and avoid the use of one tmp register by the latter as well.
> 
> In order to make the code more readable, this also introduces helper routines `subi`/`subiw` and adapts callsites of `addi`/`addiw` with negative immediates.
> 
> 
> 
>  <Design of the RISC-V Instruction Set Architecture>:
> 
>  There is no SUBI instruction, because ADDI with a negative immediate is almost equivalent. The one
>  exception arises from the asymmetry of the twos complement representation: SUBI with an immediate of
>  -2048 would add 2048 to a register, which ADDI is incapable of.
> 
> 
> Testing on Premier-P550 SBC running Ubuntu-24.04:
> - [x] : tier1-3 and gtest:all (release)
> - [x] : hotspot:tier1 (fastdebug)

Fei Yang has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains seven additional commits since the last revision:

 - Merge branch 'master' into JDK-8346478
 - Review comments
 - Revert unnecessary change
 - Improve naming for rotate routines
 - Revert unnecessary changes
 - Merge branch 'master' into JDK-8346478
 - 8346478: RISC-V: Refactor add/sub assembler routines

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/22804/files
  - new: https://git.openjdk.org/jdk/pull/22804/files/ba5f37cc..54177bbf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=22804&range=06
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=22804&range=05-06

  Stats: 21268 lines in 372 files changed: 8739 ins; 10907 del; 1622 mod
  Patch: https://git.openjdk.org/jdk/pull/22804.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/22804/head:pull/22804

PR: https://git.openjdk.org/jdk/pull/22804


More information about the hotspot-dev mailing list