RFR: 8313396: Portable implementation of FORBID_C_FUNCTION and ALLOW_C_FUNCTION [v2]

[David Holmes]

On Thu, 9 Jan 2025 06:31:55 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Yes, I think it's fine to say !WINDOWS instead of listing all the posix ports.  We've been avoiding dispatch files and once it reaches a threshold of too many #ifdef !WINDOWS #include posix.hpp one, then we could add another macro like the OS_CPU one.
>> 
>> Also the copyright script added 2025 for these because they started with 2024 so it's sort of a bug in the script but not really solvable because it doesn't know that you didn't check this in in 2024.
>
> @coleenp The copyrights on the new files being 2024-2025 is intentional. They were first published (in this PR)
> in 2024, so I think are supposed to have that starting year.

@kimbarrett I understand. I also don't like the includer needing to know about this, and maybe it is time to add OS_FAMILY_HEADER to deal with it. But in the absence of the new macro I prefer this break of abstraction to the creation of a bunch of tiny forwarding files.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22890#discussion_r1909925627