RFR: 8345314: Add a red–black tree as a utility data structure [v11]
Casper Norrbin
cnorrbin at openjdk.org
Fri Jan 10 10:03:22 UTC 2025
On Thu, 9 Jan 2025 16:12:30 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Improved comments
>
> src/hotspot/share/utilities/rbTree.hpp line 42:
>
>> 40: // Key needs to be of a type that is trivially destructible.
>> 41: // The tree will call a value's destructor when its node is removed.
>> 42: // Nodes are address stable and will not change during its lifetime unless modified by the user.
>
> How would a node's address be modified by the user? The address never changes!
Removed the last part. I was trying to say that the content of a node never changes (unlike previously) unless the user explicitly changes the value.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22360#discussion_r1910123322
More information about the hotspot-dev
mailing list