RFR: 8347343: RISC-V: Unchecked zicntr csr reads

Robbin Ehn rehn at openjdk.org
Fri Jan 10 11:04:42 UTC 2025


On Fri, 10 Jan 2025 10:38:57 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> As these instructions are unused, no need to enable them, I'm hesitant to add an NO-OP option.
>> I figured that when we add uses fom them we can add that option, if needed.
>> 
>> Should I really add such dummy option?
>
> Or simply remove this `VM_Version::ext_Zicntr.enabled()` check from the assert for now? (It's a NO-OP too as it always returns false :-)) We can add it back together with option `UseZicntr` when we have hwprobe for this.

Ok!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23003#discussion_r1910214055


More information about the hotspot-dev mailing list