RFR: 8347343: RISC-V: Unchecked zicntr csr reads [v2]

[Fei Yang]

On Fri, 10 Jan 2025 11:42:15 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> The rdinstret/rdcycle/rdtime are really useful and would be great to add in e.g. JFR.
>> But as of now they are not used and zicntr is not yet in hwprobe therefore this patch just make sure they can't be used.
>> 
>> If we need them before hwprobe we can add a flag for manually enabling them.
>> 
>> Sanity tested.
>> 
>> Thanks!
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Review comments

Thanks for the update.

src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 52:

> 50: #include "runtime/sharedRuntime.hpp"
> 51: #include "runtime/stubRoutines.hpp"
> 52: #include "vm_version_riscv.hpp"

Do we still need this header then?

-------------

Marked as reviewed by fyang (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23003#pullrequestreview-2542246223
PR Review Comment: https://git.openjdk.org/jdk/pull/23003#discussion_r1910266143