RFR: 8344140: Refactor the discovery of AOT cache artifacts [v7]
Ioi Lam
iklam at openjdk.org
Tue Jan 14 19:50:03 UTC 2025
> This is a clean up after the initial integration for [JEP 483](https://bugs.openjdk.org/browse/JDK-8315737)
>
> - Merged 3 loops into 1 for discovering the classes and oops that should be stored in the AOT cache. About 250 lines of code are deleted.
> - Added comments in aotArtifactFinder.hpp to describe the logic, which is much simpler than before.
> - Enum classes are no longer unconditionally AOT-initialized -- an Enum class is AOT-initialized only if we find an archived oop of this type.
>
> Note to reviewers:
>
> One consequence of this refactoring is that archived oops are now discovered (by heapShared.cpp) before the metadata are copied (by ArchiveBuilder). There are some functions that depend on the old order (metadata were copied before oop discovery), so I had to shuffle them around. Examples are `Modules::check_archived_module_oop()`, or the new code in `Klass::remove_java_mirror()`.
Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 13 commits:
- Merge branch 'master' into 8344140-consolidate-aot-artifact-gathering-discovery
- @calvinccheung comments
- Updated copyright
- Merge branch 'master' into 8344140-consolidate-aot-artifact-gathering-discovery
- @ashu-mehra comments
- Merge branch 'master' into 8344140-consolidate-aot-artifact-gathering-discovery
- Merge branch 'master' of https://github.com/openjdk/jdk into 8344140-consolidate-aot-artifact-gathering-discovery
- Fixe 32-bit builds; removed unused function
- more clean up
- tmp
- ... and 3 more: https://git.openjdk.org/jdk/compare/2de71d04...07cacbd0
-------------
Changes: https://git.openjdk.org/jdk/pull/22291/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=22291&range=06
Stats: 1356 lines in 29 files changed: 563 ins; 679 del; 114 mod
Patch: https://git.openjdk.org/jdk/pull/22291.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/22291/head:pull/22291
PR: https://git.openjdk.org/jdk/pull/22291
More information about the hotspot-dev
mailing list