RFR: 8344140: Refactor the discovery of AOT cache artifacts [v3]

[Ioi Lam]

On Tue, 7 Jan 2025 22:52:16 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains eight commits:
>> 
>>  - Merge branch 'master' into 8344140-consolidate-aot-artifact-gathering-discovery
>>  - Merge branch 'master' of https://github.com/openjdk/jdk into 8344140-consolidate-aot-artifact-gathering-discovery
>>  - Fixe 32-bit builds; removed unused function
>>  - more clean up
>>  - tmp
>>  - More clean up
>>  - Removed unnecessary code
>>  - 8344140: Consolidate AOT cache code for artifact discovery
>
> Comment in `AOTClassInitializer::can_archive_initialized_mirror()` refers to `HeapShared::find_all_aot_initialized_classes()` which does not exist anymore:
> 
> 
>   // When CDSConfig::is_initing_classes_at_dump_time() is enabled,
>   // HeapShared::find_all_aot_initialized_classes() finds the classes of all
>   // heap objects that are reachable from HeapShared::_run_time_special_subgraph,
>   // and mark these classes as aot-inited.
> 
> 
> And this comment at line 263 in `aotClassInitializer.cpp` also needs to be updated as the enum classes are not unconditionally AOT-initialized:
> 
> 
>       // above we selected all enums; we must include their super as well
>       {"java/lang/Enum"},

Thanks @ashu-mehra and @calvinccheung for the review.
I've tested against tiers 1~4 and builds-tier5. No new failures.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/22291#issuecomment-2591628370