RFR: 8343767: Enumerate StubGen blobs, stubs and entries and generate code from declarations [v13]

[Martin Doerr]

On Wed, 15 Jan 2025 14:00:01 GMT, Andrew Dinn <adinn at openjdk.org> wrote:

>> Implementation of JDK-8343767
>
> Andrew Dinn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   update copyrights

We have also run tests and found a problem while running TestCodeEntryAlignment on MacOS x64:

assert(allocates2(pc)) failed: not in CodeBuffer memory: 0x0000000116f36800 <= 0x0000000116f4a941 <= 0x0000000116f4a940



V  [libjvm.dylib+0x2cfa52]  AbstractAssembler::emit_int24(int, int, int)+0x112
V  [libjvm.dylib+0x2d5a2c]  Assembler::vex_prefix_and_encode(int, int, int, Assembler::VexSimdPrefix, Assembler::VexOpcode, InstructionAttr*, bool, bool, bool)+0x19c
V  [libjvm.dylib+0x3681d8]  Assembler::rorxq(Register, Register, int)+0x98
V  [libjvm.dylib+0xe5232c]  MacroAssembler::sha512_AVX2_one_round_compute(Register, Register, Register, Register, Register, Register, Register, Register, Register, int)+0x1ac
V  [libjvm.dylib+0xe54222]  MacroAssembler::sha512_AVX2(XMMRegister, XMMRegister, XMMRegister, XMMRegister, XMMRegister, XMMRegister, XMMRegister, XMMRegister, Register, Register, Register, Register, Register, bool, XMMRegister)+0x1552
V  [libjvm.dylib+0x12ba8a4]  StubGenerator::generate_sha512_implCompress(StubGenStubId)+0xf4
V  [libjvm.dylib+0x12c4d42]  StubGenerator::generate_compiler_stubs()+0x8d2
V  [libjvm.dylib+0x12c563a]  StubGenerator_generate(CodeBuffer*, StubGenBlobId)+0x1a
V  [libjvm.dylib+0x1324efb]  initialize_stubs(StubGenBlobId, int, int, char const*, char const*, char const*)+0xcb
V  [libjvm.dylib+0x1325376]  compiler_stubs_init(bool)+0x96
V  [libjvm.dylib+0x4cb317]  C2Compiler::init_c2_runtime()+0x117


In addition, gc/shenandoah/TestStringInternCleanup_default failed on MacOS aarch64 and linuxmuslx86_64:

assert(nk >= _lowest_valid_narrow_klass_id && nk <= _highest_valid_narrow_klass_id) failed: narrowKlass ID out of range (3131947710)



V  [libjvm.dylib+0x59052c]  print_error_for_unit_test(char const*, char const*, char*)+0x0
V  [libjvm.dylib+0x59f294]  PromoteFailureClosure::do_oop(oop*)+0x0
V  [libjvm.dylib+0x727f5c]  oopDesc::klass() const+0xfc
V  [libjvm.dylib+0x8b1c38]  java_lang_String::equals(oop, oop)+0xa0
V  [libjvm.dylib+0x118b548]  StringTableLookupOop::equals(WeakHandle*)+0xec
V  [libjvm.dylib+0x118b390]  ConcurrentHashTable<StringTableConfig, (MemTag)11>::Node* ConcurrentHashTable<StringTableConfig, (MemTag)11>::get_node<StringTableLookupOop>(ConcurrentHashTable<StringTableConfig, (MemTag)11>::Bucket const*, StringTableLookupOop&, bool*, unsigned long*) const+0x80
V  [libjvm.dylib+0x118c050]  bool ConcurrentHashTable<StringTableConfig, (MemTag)11>::internal_insert_get<StringTableLookupOop, bool ConcurrentHashTable<StringTableConfig, (MemTag)11>::insert<StringTableLookupOop>(Thread*, StringTableLookupOop&, WeakHandle const&, bool*, bool*)::NOP>(Thread*, StringTableLookupOop&, WeakHandle const&, bool ConcurrentHashTable<StringTableConfig, (MemTag)11>::insert<StringTableLookupOop>(Thread*, StringTableLookupOop&, WeakHandle const&, bool*, bool*)::NOP&, bool*, bool*)+0x178
V  [libjvm.dylib+0x1187684]  StringTable::do_intern(StringWrapperInternal const&, unsigned long, JavaThread*)+0x234
V  [libjvm.dylib+0x1187074]  StringTable::intern(StringWrapperInternal const&, JavaThread*)+0x238
V  [libjvm.dylib+0x11872a4]  StringTable::intern(oop, JavaThread*)+0x1b4
V  [libjvm.dylib+0xa39b30]  JVM_InternString+0x148

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21957#issuecomment-2598064527