RFR: 8347343: RISC-V: Unchecked zicntr csr reads [v3]

Hamlin Li mli at openjdk.org
Fri Jan 17 14:49:41 UTC 2025


On Fri, 10 Jan 2025 11:59:10 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> Hi, please consider.
>> 
>> The rdinstret/rdcycle/rdtime are really useful and would be great to add in e.g. JFR.
>> But as of now they are not used and zicntr is not yet in hwprobe therefore this patch just make sure they can't be used.
>> 
>> If we need them before hwprobe we can add a flag for manually enabling them.
>> 
>> Sanity tested.
>> 
>> Thanks!
>
> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Remove header

Looks good.

-------------

Marked as reviewed by mli (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23003#pullrequestreview-2559204355


More information about the hotspot-dev mailing list