RFR: 8347981: RISC-V: Add Zfa zli imm loads [v2]

[Ludovic Henry]

On Sat, 18 Jan 2025 08:42:29 GMT, Robbin Ehn <rehn at openjdk.org> wrote:

>> src/hotspot/cpu/riscv/macroAssembler_riscv.cpp line 2645:
>> 
>>> 2643:   }
>>> 2644:   int Rs = -1;
>>> 2645:   can_zfa_zli_double(imm, &Rs);
>> 
>> should that be a `guarantee(can_zfa_zli_double(imm, &Rs));`?
>
> Sorry my bad for not adding a comment.
> I'm using the guarantee in zli_d on that Rs is uimm5.
> 
> As we already an guarantee, maybe assert(can_zfa..) ?

`assert(can_zfa..)` are not compiled in on release builds. You could then have `bool ret = can_zfa_zli_double(imm, &Rs); assert(ret);`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23171#discussion_r1921061045