RFR: 8347794: RISC-V: Add Zfhmin - Float cleanup [v2]
Robbin Ehn
rehn at openjdk.org
Mon Jan 20 07:35:12 UTC 2025
On Mon, 20 Jan 2025 03:11:21 GMT, Fei Yang <fyang at openjdk.org> wrote:
> Thanks for making this cleanup! I only have one minor comment.
Thanks!
> src/hotspot/cpu/riscv/assembler_riscv.hpp line 977:
>
>> 975: public:
>> 976:
>> 977: enum FClassBit {
>
> Since we have composed members like `zero`, `subnorm` etc. , maybe we should rename this to `FClassBits`?
Yes!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23130#issuecomment-2601622137
PR Review Comment: https://git.openjdk.org/jdk/pull/23130#discussion_r1921914789
More information about the hotspot-dev
mailing list