RFR: 8345285: [s390x] test failures: foreign/normalize/TestNormalize.java with C2

Martin Doerr mdoerr at openjdk.org
Mon Jan 20 13:47:35 UTC 2025


On Mon, 20 Jan 2025 11:24:39 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:

> Fixes `foreign/normalize/TestNormalize.java` failure on s390x.

I was wondering why the entry frame uses the "extended sp" while the upcall stub should use the "unextended sp".
This seems to be due to the fact that the normal entries use `from_interpreted_entry()`:
https://github.com/openjdk/jdk/blob/9346984725ed09e9917e825094b34c3a033af23e/src/hotspot/share/runtime/javaCalls.cpp#L397
The upcall stubs load the call target address from `Method::from_compiled_offset()` and use c2i if needed.
So, it looks correct to me. But the PR should get a 2nd review.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/23197#pullrequestreview-2562434223


More information about the hotspot-dev mailing list