RFR: 8347794: RISC-V: Add Zfhmin - Float cleanup [v3]

Robbin Ehn rehn at openjdk.org
Mon Jan 20 13:48:52 UTC 2025


On Mon, 20 Jan 2025 11:53:15 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   FClassBits
>
> src/hotspot/cpu/riscv/assembler_riscv.hpp line 927:
> 
>> 925:   template <FmtPrecision Fmt, uint8_t funct5>
>> 926:   void fp_base(FloatRegister Rd, FloatRegister Rs1, FloatRegister Rs2, RoundingMode rm) {
>> 927:     fp_base<Fmt, funct5>(Rd->raw_encoding(), Rs1->raw_encoding(), Rs2->raw_encoding(), (RoundingMode)rm);
> 
> Nit: Is this explicit type conversion necessary here? `(RoundingMode)rm`

No, thanks!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23130#discussion_r1922429056


More information about the hotspot-dev mailing list