RFR: 8348040: Bad use of ifdef with INCLUDE_xxx GC macros

David Holmes dholmes at openjdk.org
Mon Jan 20 20:34:38 UTC 2025


On Mon, 20 Jan 2025 09:23:01 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The `INCLUDE_xxx` macros should be used with `#if` not `#ifdef` as the value is alway defined as either 1 or 0. So with `#ifdef` the guard is always true. This would lead to build problems in some cases if you built a configuration without the specified GC.
>> 
>> Testing:
>>  - tiers 1-3 sanity
>>  - tiers 4-5 builds
>> 
>> Thanks
>
> Marked as reviewed by stefank (Reviewer).

Thanks for the reviews @stefank and @shipilev !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23193#issuecomment-2603190039


More information about the hotspot-dev mailing list