Integrated: 8348040: Bad use of ifdef with INCLUDE_xxx GC macros
David Holmes
dholmes at openjdk.org
Mon Jan 20 20:34:38 UTC 2025
On Sun, 19 Jan 2025 21:15:56 GMT, David Holmes <dholmes at openjdk.org> wrote:
> The `INCLUDE_xxx` macros should be used with `#if` not `#ifdef` as the value is alway defined as either 1 or 0. So with `#ifdef` the guard is always true. This would lead to build problems in some cases if you built a configuration without the specified GC.
>
> Testing:
> - tiers 1-3 sanity
> - tiers 4-5 builds
>
> Thanks
This pull request has now been integrated.
Changeset: 955bf185
Author: David Holmes <dholmes at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/955bf185c38ec0fcedb0a549461fc85367b37fbb
Stats: 8 lines in 3 files changed: 0 ins; 1 del; 7 mod
8348040: Bad use of ifdef with INCLUDE_xxx GC macros
Reviewed-by: stefank, shade
-------------
PR: https://git.openjdk.org/jdk/pull/23193
More information about the hotspot-dev
mailing list