RFR: 8347981: RISC-V: Add Zfa zli imm loads [v2]
Fei Yang
fyang at openjdk.org
Tue Jan 21 02:39:38 UTC 2025
On Sat, 18 Jan 2025 09:14:17 GMT, Robbin Ehn <rehn at openjdk.org> wrote:
>> Hi, please consider!
>>
>> This patch the Zfa zli floating point immediate load.
>> As a bonus it adds fmv_?_x(Rd, zr); for loading fp/dp 0x0.
>> There are some more instruction in Zfa, but this was such a clear use-case so I only did fli as a start.
>>
>> When using one of the 32 'popular' floats we can now materialze them without a load.
>> E.g.
>> `float f = f1 * 0.5 + f2 * 2.0;`
>> Only require 2 loads instead of 4: as '0.5' and '2.0' is such popular float values.
>>
>> As Java is often memory bound we should also investigate doing lui+ssli+fmv for float/doubles instead of a load when materializing.
>>
>> Note the _fli_s/_fli_d will be proper merged on the 8347794: RISC-V: Add Zfhmin - Float cleanup.
>>
>> Passes:
>> ./test/jdk/java/lang/Math
>> ./test/hotspot/jtreg/compiler/floatingpoint/
>> ./test/jdk/java/util/Formatter/
>> ./test/jdk/java/lang/Float/
>> ./test/jdk/java/lang/Double/
>> ./test/hotspot/jtreg/compiler/c2/FloatingPointFoldingTest.java
>> ./test/hotspot/jtreg/compiler/eliminateAutobox/
>> ./test/hotspot/jtreg/vmTestbase/jit/
>>
>> Running tier1
>>
>> Thanks!
>
> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>
> - Flip bool static decl
> - Merge branch 'master' into zfa
> - Baseline
src/hotspot/cpu/riscv/globals_riscv.hpp line 106:
> 104: product(bool, UseZbb, false, DIAGNOSTIC, "Use Zbb instructions") \
> 105: product(bool, UseZbs, false, DIAGNOSTIC, "Use Zbs instructions") \
> 106: product(bool, UseZfa, false, DIAGNOSTIC, "Use Zfa instructions") \
Is there any hardware available for testing?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23171#discussion_r1922959920
More information about the hotspot-dev
mailing list