RFR: 8347794: RISC-V: Add Zfhmin - Float cleanup [v4]

Robbin Ehn rehn at openjdk.org
Tue Jan 21 08:28:23 UTC 2025


On Tue, 21 Jan 2025 01:12:58 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Fix nit
>>  - Merge branch 'master' into zfhmin
>>  - FClassBits
>>  - Merge branch 'master' into zfhmin
>>  - Baseline
>
> src/hotspot/cpu/riscv/assembler_riscv.hpp line 941:
> 
>> 939: 
>> 940:   template <FmtPrecision Fmt, uint8_t funct5>
>> 941:   void fp_base(FloatRegister Rd, FloatRegister Rs1, int Rs2, int8_t rm) {
> 
> Minor question: Should `int Rs2` be `uint8_t Rs2` for consistency with friends?

Yes, thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23130#discussion_r1923262888


More information about the hotspot-dev mailing list