RFR: 8348117: The two-argument overload of SignatureHandlerLibrary::add is not used

[David Holmes]

On Tue, 21 Jan 2025 12:22:26 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> The  `SignatureHandlerLibrary::add` two-arg API was added to support closed code under [JDK-8087333](https://bugs.openjdk.org/browse/JDK-8087333) in JDK 9. That closed code was removed again, still in JDK 9, as part of JEP 297 ([JDK-8168503](https://bugs.openjdk.org/browse/JDK-8168503)) which unified the closed and open ARM ports - leaving the API unused.
>> 
>> There were other leftovers from the same set of changes so they are cleaned up as well - nothing significant, just unnecessary friend declarations, comments, and one other method.
>> 
>> Testing:
>>  - all builds in tiers 1-5
>> 
>> Thanks.
>
> Looks good!

Thanks for the reviews @coleenp and @shipilev !

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23207#issuecomment-2605805194