RFR: JDK-8216437 : PPC64: Add intrinsic for GHASH algorithm [v9]
Martin Doerr
mdoerr at openjdk.org
Thu Jan 23 10:21:57 UTC 2025
On Wed, 22 Jan 2025 11:57:58 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:
>> Suchismith Roy has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 37 commits:
>>
>> - spaces
>> - Merge branch 'master' into ghash_processblocks
>> - spaces
>> - update references
>> - Comments and vsx check
>> - restore
>> - assertion for blocks
>> - assertion for blocks
>> - clearing bits
>> - clearing bits
>> - ... and 27 more: https://git.openjdk.org/jdk/compare/d777218f...b04b6924
>
> src/hotspot/cpu/ppc/vm_version_ppc.cpp line 314:
>
>> 312: else if (UseGHASHIntrinsics) {
>> 313: FLAG_SET_DEFAULT(UseGHASHIntrinsics, true);
>> 314: }
>
> This looks broken. Please take a look how it is implemented for `UseAES`.
hotspot uses 2 spaces indentation. Otherwise, it looks good. We'll test it. Reviewing the algorithm will need some more time.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20235#discussion_r1926726175
More information about the hotspot-dev
mailing list