RFR: 8344232: [PPC64] secondary_super_cache does not scale well: C1 and interpreter [v2]

Richard Reingruber rrich at openjdk.org
Thu Jan 23 14:26:51 UTC 2025


On Thu, 23 Jan 2025 14:04:21 GMT, Martin Doerr <mdoerr at openjdk.org> wrote:

>> src/hotspot/cpu/ppc/macroAssembler_ppc.cpp line 2158:
>> 
>>> 2156:   std(super_klass, target_offset, sub_klass); // save result to cache
>>> 2157:   if (result_reg != noreg) { li(result_reg, 0); } // load zero result (indicates a hit)
>>> 2158:   if (L_success != nullptr) { b(*L_success); }
>> 
>> Handling `L_success != nullptr` should be put on the else-branch of the previous if-statement.
>
> Doesn't make a real difference, but I've cleaned it up.

Thanks. It matches the assertion you've added. I like consistency. It helps understanding stuff.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22881#discussion_r1927064061


More information about the hotspot-dev mailing list