RFR: 8344802: Crash in StubRoutines::verify_mxcsr with -XX:+EnableX86ECoreOpts and -Xcheck:jni [v3]

[Jorn Vernee]

On Thu, 23 Jan 2025 18:23:01 GMT, Volodymyr Paprotski <vpaprotski at openjdk.org> wrote:

>> Volodymyr Paprotski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   whitespace
>
> src/hotspot/os_cpu/windows_x86/os_windows_x86.cpp line 185:
> 
>> 183:       // On ECore, restore with signaling flags enabled
>> 184:       MxCsr |= 0x3F;
>> 185:     }
> 
> @JornVernee I came across your comment https://github.com/openjdk/jdk/pull/14523/files#r1236920072
> 
> I believe I am following the 'spirit' of that comment here, but would appreciate you having a look.

Yes, I think so. Originally I was seeing some cases where we were always resetting MxCsr, even for unrelated exceptions. The new code still only resets it for the FLT_* exceptions.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22673#discussion_r1928894440