RFR: 8348349: Refactor CDSConfig::is_dumping_heap() [v2]
Ioi Lam
iklam at openjdk.org
Mon Jan 27 05:51:58 UTC 2025
> Please review this small clean up:
>
> `HeapShared::can_write()` and `CDSConfig::is_dumping_heap()` are both for deciding whether CDS should dump heap objects. I removed the former and consolidated all the logic to the latter.
>
> I also updated the logging message in case heap objects cannot be dumped.
>
> I also updated VMProps to clarify what `vmCDSCanWriteArchivedJavaHeap()` means.
Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
@matias9927 comment
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/23249/files
- new: https://git.openjdk.org/jdk/pull/23249/files/5993ef74..a6a77ca7
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=23249&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=23249&range=00-01
Stats: 10 lines in 1 file changed: 0 ins; 7 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/23249.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/23249/head:pull/23249
PR: https://git.openjdk.org/jdk/pull/23249
More information about the hotspot-dev
mailing list