RFR: 8321529: log_on_large_pages_failure reports log_debug(gc, heap, coops) for ReservedCodeSpace failures

[Evgeny Astigeevich]

On Fri, 24 Jan 2025 11:29:43 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> The code path that we use to reserve memory is generic and used by various paths in the JVM, but we log messages about failures to reserve large pages on the 'gc, heap, coops' tag set. This is confusing, so I propose to log this on 'os, map' instead. We already use that tag set to log memory reservation, so I think that's a decent tag set to use.
> 
> While doing this change I also added some extra info about the area that we tried to reserve and commit.
> 
> A couple of G1 tests had to be tweaked.

Changes requested by eastigeevich (Committer).

src/hotspot/share/memory/memoryReserver.cpp line 65:

> 63: static void log_on_large_pages_failure(char* req_addr, size_t bytes) {
> 64:   if (large_pages_requested()) {
> 65:     // Compressed oops logging.

I think we don't need this comment any more.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23297#pullrequestreview-2576189054
PR Review Comment: https://git.openjdk.org/jdk/pull/23297#discussion_r1930976317