RFR: 8321529: log_on_large_pages_failure reports log_debug(gc, heap, coops) for ReservedCodeSpace failures
Evgeny Astigeevich
eastigeevich at openjdk.org
Mon Jan 27 18:04:58 UTC 2025
On Mon, 27 Jan 2025 17:48:12 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> The code path that we use to reserve memory is generic and used by various paths in the JVM, but we log messages about failures to reserve large pages on the 'gc, heap, coops' tag set. This is confusing, so I propose to log this on 'os, map' instead. We already use that tag set to log memory reservation, so I think that's a decent tag set to use.
>>
>> While doing this change I also added some extra info about the area that we tried to reserve and commit.
>>
>> A couple of G1 tests had to be tweaked.
>
> LGTM
> Note that I used JDK-8321529, which is a bug that @eastig created a over a year ago. Evgeny do you think this is a decent fix? Or do you need something else? Is it OK if I make this change under your bug or do you want me to create a separate bug for this change?
Hi @stefank,
Thanks for fixing the issue.
I don't think we need another bug.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/23297#issuecomment-2616526535
More information about the hotspot-dev
mailing list