RFR: 8321529: log_on_large_pages_failure reports log_debug(gc, heap, coops) for ReservedCodeSpace failures [v2]
Stefan Karlsson
stefank at openjdk.org
Mon Jan 27 18:19:06 UTC 2025
On Mon, 27 Jan 2025 18:02:12 GMT, Evgeny Astigeevich <eastigeevich at openjdk.org> wrote:
>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Update memoryReserver.cpp
>
> src/hotspot/share/memory/memoryReserver.cpp line 65:
>
>> 63: static void log_on_large_pages_failure(char* req_addr, size_t bytes) {
>> 64: if (large_pages_requested()) {
>> 65: // Compressed oops logging.
>
> I think we don't need this comment any more.
+1 I removed it.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23297#discussion_r1930991195
More information about the hotspot-dev
mailing list