RFR: 8321529: log_on_large_pages_failure reports log_debug(gc, heap, coops) for ReservedCodeSpace failures [v2]

[David Holmes]

On Mon, 27 Jan 2025 18:19:04 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The code path that we use to reserve memory is generic and used by various paths in the JVM, but we log messages about failures to reserve large pages on the 'gc, heap, coops' tag set. This is confusing, so I propose to log this on 'os, map' instead. We already use that tag set to log memory reservation, so I think that's a decent tag set to use.
>> 
>> While doing this change I also added some extra info about the area that we tried to reserve and commit.
>> 
>> A couple of G1 tests had to be tweaked.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update memoryReserver.cpp

In the context of where this code was originally added ([JDK-8265268](https://bugs.openjdk.org/browse/JDK-8265268)), in `virtualSpace.cpp` the use of `log_debug(gc, heap, coops)` was consistent with, and formed part of the tracing for, all the memory logging in that code. I don't disagree that you might want to more generically enable this logging, but it will now be missing from that established logging path. It doesn't affect me either way, but people who use that logging may have a stronger opinion.

-------------

PR Review: https://git.openjdk.org/jdk/pull/23297#pullrequestreview-2582809252