RFR: 8337217: Port VirtualMemoryTracker to use VMATree [v18]

Afshin Zafari azafari at openjdk.org
Thu Jan 30 09:42:56 UTC 2025


On Wed, 29 Jan 2025 16:57:09 GMT, Robert Toyonaga <duke at openjdk.org> wrote:

>> Afshin Zafari has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   merge with the new lock mechanism for NMT
>
> src/hotspot/os/windows/os_windows.cpp line 3642:
> 
>> 3640:       log_warning(os)("bad release: [" PTR_FORMAT "-" PTR_FORMAT "): %s", p2i(start), p2i(end), err);
>> 3641: #ifdef ASSERT
>> 3642:       os::print_memory_mappings((char*)start, bytes, tty);
> 
> I think this will cause lock rank conflicts if you leave it in.  Please see [here](https://github.com/openjdk/jdk/pull/22745#discussion_r1890345578) and [here](https://github.com/openjdk/jdk/pull/22745#discussion_r1894197615) for more context.

Thanks. This is a mistake during merge, no intention to write so. Removed to look like the PR you referred.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20425#discussion_r1935298542


More information about the hotspot-dev mailing list