RFR: 8321529: log_on_large_pages_failure reports log_debug(gc, heap, coops) for ReservedCodeSpace failures [v2]

Stefan Karlsson stefank at openjdk.org
Thu Jan 30 09:47:49 UTC 2025


On Mon, 27 Jan 2025 18:19:04 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The code path that we use to reserve memory is generic and used by various paths in the JVM, but we log messages about failures to reserve large pages on the 'gc, heap, coops' tag set. This is confusing, so I propose to log this on 'os, map' instead. We already use that tag set to log memory reservation, so I think that's a decent tag set to use.
>> 
>> While doing this change I also added some extra info about the area that we tried to reserve and commit.
>> 
>> A couple of G1 tests had to be tweaked.
>
> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update memoryReserver.cpp

So, at one point it was consistent but then that deteriorated and we started to log to gc+heap+oops for things that are not related to the heap or the compressed oops. 

If anyone has an opinion about this logging then please participate in this PR.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23297#issuecomment-2623995304


More information about the hotspot-dev mailing list