RFR: 8349003: NativeCallStack::print_on() output is unreadable

Thomas Stuefe stuefe at openjdk.org
Thu Jan 30 10:49:48 UTC 2025


On Thu, 30 Jan 2025 07:25:48 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

>> Please review this trivial change that improves output readability.
>
> I don't understand, where did we break this? Did I break this with [8333994](https://github.com/openjdk/jdk/pull/19655/files#top)?
> 
> If so, why did NMT tests not fall all over the place? They should have catched such a regression.

> I reported this last year https://bugs.openjdk.org/browse/JDK-8344603 and the runtime triaged and assigned it to you @tstuefe . But I guess something fell through the cracks.

Oh, I missed that one completely :-( No, you are right, that is a bug that needs fixing. Weird that it only shows up at some output lines. @zhengyu123 by adding a single cr, looking at https://bugs.openjdk.org/browse/JDK-8344603, would we not now show multiple newlines in some places?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23359#issuecomment-2624139021


More information about the hotspot-dev mailing list