RFR: 8343767: Enumerate StubGen blobs, stubs and entries and generate code from declarations [v13]
Andrew Dinn
adinn at openjdk.org
Thu Jan 30 13:48:58 UTC 2025
On Thu, 30 Jan 2025 12:50:29 GMT, Fei Yang <fyang at openjdk.org> wrote:
>> @iwanowww @TheRealMDoerr The x86 failure happens when the test sets code cache segment size and alignment both to 1024. There are so many stubs in the compiler blob on x86_64 that this requires an extra 8000 bytes to be added to the current blob size. The slop for this case is only 900 bytes but the test is a fairly unrealistic scenario. With both values set to 512 we have over 13000 bytes of slop. So, I think I have added enough for realistic purposes.
>
> @adinn : Witnessed build errors after this change. Seems that this PR needs rebase before merging. It's strange that the bot didn't catch the merge conflicts in files like `src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp` or `src/hotspot/cpu/riscv/stubGenerator_riscv.cpp`.
@RealFYang Thanks for notifying this do quickly. I'm not sure how the bots didn't catch this either. Most of the conflicts were in copyright headers so would not be caught by the testing. There were two unresolved merge conflicts in the ppc and riscv code which also crept in and were not detected by github actions.
I have opened [JDK-8349070](https://bugs.openjdk.org/browse/JDK-8349070) and will push a PR to fix it asap.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21957#issuecomment-2624549335
More information about the hotspot-dev
mailing list