RFR: 8360707: Globally enumerate all blobs, stubs and entries

[Andrew Dinn]

On Mon, 30 Jun 2025 20:47:05 GMT, Vladimir Kozlov <kvn at openjdk.org> wrote:

>> Use the blob, stub and entry declarations to generate a single global enumeration for all blobs, likewise for all stubs and all entries. Modify stub generators in shared runtime, c1 runtime, c2 runtime and stub generator subsystems and their clients to use those enumerations consistently.
>
> src/hotspot/share/runtime/stubCodeGenerator.hpp line 109:
> 
>> 107:   bool _print_code;
>> 108:   BlobId _blob_id;
>> 109: protected:
> 
> Please return spacing for `protected:` line.

Done

> src/hotspot/share/runtime/stubCodeGenerator.hpp line 118:
> 
>> 116: 
>> 117:   MacroAssembler* assembler() const              { return _masm; }
>> 118:   BlobId blob_id()                        { return _blob_id; }
> 
> Align body of methods. May be move them to the left - I don't see why we have such big spacing.

I believe the spacing is meant to align with the declarations that follow.

I have simply realigned the modified line with the old line to avoid unnecessary changes.

> src/hotspot/share/runtime/stubDeclarations.hpp line 1235:
> 
>> 1233:                  do_arch_entry, do_arch_entry_init)                     \
>> 1234: 
>> 1235: 
> 
> No need this empty line.

Removed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2176858735
PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2176856030
PR Review Comment: https://git.openjdk.org/jdk/pull/26004#discussion_r2176859879